Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuejs 3 Bugfix for adding Eventlisteners #814

Closed
wants to merge 1 commit into from

Conversation

danielDigitalArt
Copy link

Error-Message was:
Uncaught (in promise) TypeError: Cannot convert undefined or null to object
at Function.keys ()
at Proxy.addEventListener

Reason:
$listeners was removed in vue 3, see: https://v3-migration.vuejs.org/breaking-changes/listeners-removed.html

Hotfix:
Prevent error messages by ignoring listeners, when not set. Will surely prevent Listeners from being properly registered/executed.

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Error-Message was:
Uncaught (in promise) TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at Proxy.addEventListener

Reason:
$listeners was removed in vue 3, see: https://v3-migration.vuejs.org/breaking-changes/listeners-removed.html

Hotfix:
Prevent error messages by ignoring listeners, when not set. Will surely prevent Listeners from being properly registered/executed.
@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Oct 30, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant