feat: restrict zoomed image goes out of canvas #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elli-Jeon
changed the title
lja1018
reviewed
Apr 27, 2022
Comment on lines
585
to
595
| if (vpt[4] >= 0) { | ||
| vpt[4] = 0; | ||
| } else if (vpt[4] < canvasWidth - canvasWidth * zoomLevel) { | ||
| vpt[4] = canvasWidth - canvasWidth * zoomLevel; | ||
| } | ||
|
|
||
| if (vpt[5] >= 0) { | ||
| vpt[5] = 0; | ||
| } else if (vpt[5] < canvasHeight - canvasHeight * zoomLevel) { | ||
| vpt[5] = canvasHeight - canvasHeight * zoomLevel; | ||
| } |
There was a problem hiding this comment.
Why don't you use util/clamp?
|
This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks! |
|
This issue will be closed due to inactivity. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Good day!
problem
if user download the image, blank space also comes out there, too.
enhancement
reference
Thank you
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨