Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load-image init event error #75

Merged
merged 2 commits into from
Oct 19, 2018
Merged

fix: load-image init event error #75

merged 2 commits into from
Oct 19, 2018

Conversation

jinwoo-kim-nhn
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn commented Oct 18, 2018 •
edited

work

  • init 이미지가 없는 상태에서 이미지Load 버튼이 정상 동작하지 않는 문제를 수정
    • addLoadEvent() 를 초기 이미지가 없는 상태에서도 항상 호출하도록 변경
    • 초기 이미지가 없는 상태에서 이미지 로드시 이미지사이즈 상태를 업데이트 해주도록 변경
  • ui.resizeEditor() 메서드를 api로 노출 하도록 jsdoc 수정

demo

seonim-ryu
seonim-ryu reviewed Oct 19, 2018
View reviewed changes
src/js/ui.js Outdated
@@ -105,6 +106,7 @@ class Ui {
* @param {Number} resizeInfo.imageSize.oldHeight - old height
* @param {Number} resizeInfo.imageSize.newWidth - new width
* @param {Number} resizeInfo.imageSize.newHeight - new height
* @api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@api 태그 안붙여도 jsdoc에 뽑혀서 나오지 않나요~?

@seonim-ryu
Copy link
Member

[10/19] 리뷰 완료하였습니다. 이견 없습니다~

@jinwoo-kim-nhn jinwoo-kim-nhn merged commit 76dba9d into master Oct 19, 2018
@junghwan-park junghwan-park deleted the fix/load-image-initevent branch January 30, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seonim-ryu seonim-ryu seonim-ryu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinwoo-kim-nhn @seonim-ryu