fix: keep shape properties form and the fabric state in sync (fix #719, #682) #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
The bugs are described in the linked issues.
The fix for updating the fill color on selecting an existing object highlights something that isn't very clear in the code. The stroke color is a simple string value for the color Hex, while the fill property is actually an object with a color and a "fill type" ( I assume to support fill patterns which I know fabric has).
Properties on an object as seen in the debugger in the objectActivated() method in actions.js