fix: keep shape properties form and the fabric state in sync (fix #719, #682)

[jaltekruse]

Please check if the PR fulfills these requirements

• It's submitted to right branch according to our branching model
• It's right issue type on title
• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes/features)
• I didn't add tests, but happy to take suggestions for the right tests to add
• Docs have been added/updated (for bug fixes/features)
• It does not introduce a breaking change or has description for the breaking change

Description

---

The bugs are described in the linked issues.

The fix for updating the fill color on selecting an existing object highlights something that isn't very clear in the code. The stroke color is a simple string value for the color Hex, while the fill property is actually an object with a color and a "fill type" ( I assume to support fill patterns which I know fabric has).

Properties on an object as seen in the debugger in the objectActivated() method in actions.js

    "fill": {
        "type": "color",
        "color": "#ff6518"
    },
    "stroke": "#03bd9e",

[lja1018]

@jaltekruse
Thank you for your contribution. I'll merge after the review.

[stale]

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

[jaltekruse]

I was testing this out manually and this isn't a complete fix, unfortunately the fill is sometimes an object and sometimes a string. I'll try to update the PR soon with a proper fix.

[lja1018]

@jaltekruse
Thank you. I'll look forward to it.

[stale]

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

[stale]

This issue will be closed due to inactivity. Thanks for your contribution!

[stale]

This issue will be closed due to inactivity. Thanks for your contribution!