Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undo/redo broken when a group is selected (fix: #546) #722

Closed
wants to merge 1 commit into from
Closed

fix: undo/redo broken when a group is selected (fix: #546) #722

wants to merge 1 commit into from

Conversation

jaltekruse
Copy link

@jaltekruse jaltekruse commented Feb 23, 2022 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • I did deliberately put this on master, I assume it is a good candidate for "bug fix or document update for next patch release." as described in the contributing guidelines
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I'm not sure if I should open a new issue, this is an improved fix for a previously reported issue, so there is already an issue and PR related to this that are both closed
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • happy to take recommendations here on how to write a test, not sure how to do that right now
  • Docs have been added/updated (for bug fixes/features) - not needed
  • It does not introduce a breaking change or has description for the breaking change no

Description

The original submitted fix for this issue didn't address the bug when the keyboard shortcut is used for undo or redo. This change works both for the buttons and for keyboard events.

@lja1018
Copy link
Contributor

lja1018 commented Feb 28, 2022

@jaltekruse
Thank you for your contribution. I will merge after a little test.

@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Mar 30, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Apr 17, 2022
@jaltekruse
Copy link
Author

I think this would still be useful to merge, I don't know if I have permission to re-open it

@lja1018
Copy link
Contributor

lja1018 commented Apr 20, 2022

@jaltekruse
I think so, too. But more tests are needed.

@lja1018 lja1018 reopened this Apr 20, 2022
@stale stale bot removed the inactive label Apr 20, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Jun 12, 2022
@stale
Copy link

stale bot commented Jun 23, 2022

This issue will be closed due to inactivity. Thanks for your contribution!

1 similar comment
@stale
Copy link

stale bot commented Jul 10, 2022

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaltekruse @lja1018