fix: Backspace does not work at text editing #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonim-ryu
reviewed
Oct 4, 2018
| * @returns {string} A DOMString containing the requested data URI. | ||
| */ | ||
| toDataURL(type) { | ||
| return this._canvas && this._canvas.toDataURL(type); | ||
| toDataURL(options) { |
There was a problem hiding this comment.
혹시 이 메서드 퍼블릭 API인가요?
만약 그렇다면.. 파라미터 타입이 변경되면 버저닝 이슈가 있겠네요 ;ㅅ;
There was a problem hiding this comment.
http:https://fabricjs.com/docs/fabric.Canvas.html#toDataURL
처음 개발할 때 패브릭 버전 확인해보면 좋을 것 같습니다~ 일단 픽스 버전으로 올리면 될듯요
|
[10/4] 리뷰 완료하였습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
텍스트 편집시 backspace가 동작하지 않는 부분을 해결
잘못된 jsdoc 주석 변경