Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented resize functionality fix #100, #342 #575

Merged
merged 26 commits into from
Apr 26, 2021
Merged

Conversation

seytar
Copy link
Contributor

@seytar seytar commented Apr 9, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributing.
It's very cool feature :)
However, the icon can be modified because we have our designer.

Once again, thank you for the contributing!!

apps/image-editor/src/css/submenu.styl Outdated Show resolved Hide resolved
apps/image-editor/src/js/command/resize.js Outdated Show resolved Hide resolved
apps/image-editor/src/js/component/resize.js Outdated Show resolved Hide resolved
… Removed unnecesary css style: .{prefix}-submenu-align-mr-0
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing. :)

I have two questions.
First of all, one test is being broken(npm run test command). Can you fix it? And could you add a test for resize?
Second, what would be the copyright on the icon you added? If there is no copyright issue, I think I will use it as it is.

apps/image-editor/src/js/action.js Outdated Show resolved Hide resolved
apps/image-editor/src/js/action.js Show resolved Hide resolved
apps/image-editor/src/js/component/resize.js Outdated Show resolved Hide resolved
apps/image-editor/src/js/component/resize.js Outdated Show resolved Hide resolved
apps/image-editor/src/js/graphics.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :) 👍

@seytar
Copy link
Contributor Author

seytar commented Apr 15, 2021

Thank you for contributing. :)

I have two questions.
First of all, one test is being broken(npm run test command). Can you fix it? And could you add a test for resize?
Second, what would be the copyright on the icon you added? If there is no copyright issue, I think I will use it as it is.

  • I fixed broken test.
  • I used that icon: Flaticon Resize and it says "Attribution is required.".
  • I can add resize tests

@seytar
Copy link
Contributor Author

seytar commented Apr 20, 2021

Thank you for contributing. :)
I have two questions.
First of all, one test is being broken(npm run test command). Can you fix it? And could you add a test for resize?
Second, what would be the copyright on the icon you added? If there is no copyright issue, I think I will use it as it is.

  • I fixed broken test.
  • I used that icon: Flaticon Resize and it says "Attribution is required.".
  • I can add resize tests

Added all tests @lja1018

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yor for your contribution. 👍 👍 👍

I have some questions.

  1. Should I add the image source to README?
  2. Please add 1 line to component/resize(import { Promise } from '@/util';). Required for old browser support :)

apps/image-editor/src/js/action.js Show resolved Hide resolved
apps/image-editor/src/js/action.js Outdated Show resolved Hide resolved
apps/image-editor/src/js/component/resize.js Show resolved Hide resolved
apps/image-editor/tests/resize.spec.js Outdated Show resolved Hide resolved
@seytar
Copy link
Contributor Author

seytar commented Apr 22, 2021

Thank yor for your contribution.

I have some questions.

  1. Should I add the image source to README?
  2. Please add 1 line to component/resize(import { Promise } from '@/util';). Required for old browser support :)
  1. I think yes.
  2. Ok, added.

@lja1018
Copy link
Contributor

lja1018 commented Apr 26, 2021

@seytar
Thank you for applying on all the reviews. :)
I will release it by next week at the latest.

@lja1018 lja1018 merged commit f627ed2 into nhn:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants