Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes the object when editing hex inputs of the color picker. (fix #504) #569

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Apr 1, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed a bug that removed the object when editing the hex input of the color picker.

  • AS-IS

    • asis
  • TO-BE

    • Object is not removed, only the input box is modified.
  • Solution

    • For each input box of submenus, add focus and blur event handler to generate inputBoxEditingStarted and inputBoxEditingStoped events to determine whether the color(hex) value is being edited or not.
    • The events in the submenu are received by the ui and re-fire, and the events are received in the imageEditor to know if the input box of the color picker is being editted.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Member

@heenakwag heenakwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@lja1018 lja1018 merged commit 300007c into master Apr 8, 2021
@lja1018 lja1018 deleted the fix/remove-object-when-hex-input-edit branch April 8, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants