Update imageEditor.js #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method to change selection styles.
|
Can one of the admins verify this patch? |
removing dist
|
Im pretty new to git. please don't commit 2nd update about gitignore |
junghwan-park
suggested changes
Jan 30, 2019
There was a problem hiding this comment.
@OculusMode
Sorry for late review. But there are some issues for your commits.
| setSelectionStyle(styles) { | ||
| this._graphics.setSelectionStyle(styles); | ||
| } | ||
|
|
There was a problem hiding this comment.
There is an option for setting selectionStyle.
I don't think this method is required.
There was a problem hiding this comment.
@junghwan-park indeed there is but only if you include ui. If you don't include UI. then there is no way to change selectionStyles i.e. cornerSize.
Hence one can use this method to do something like:
imageEditor.setSelectionStyle({ cornerSize: 10 });
|
@OculusMode |
|
@junghwan-park I have made changes in my current master, can you please re open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method to set selection style
feat: Added method to change selection styles.
Description
Added method for user to access setSelectionStyles.