Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dispose canvas resources on graphics destroy #495

Closed
wants to merge 1 commit into from

Conversation

fjwong
Copy link

@fjwong fjwong commented Dec 8, 2020

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Replaces canvas.clear() for canvas.dispose() in graphics.destroy().

I think this might be related to issues #375 and #395.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.
Thank you for your PR.
This PR will probably add to v3.11.1

@stale
Copy link

stale bot commented Jan 10, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Jan 10, 2021
@stale
Copy link

stale bot commented Jan 17, 2021

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Jan 17, 2021
@fjwong
Copy link
Author

fjwong commented Jan 18, 2021

Hello, it seems this PR has been auto-closed.

I just want to ask, are there plans to merge this at some point? Right now I have to resort to doing some hacks on my application to address the out of memory issues that this PR intends to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants