Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ability to allow developers to change colour palette preset #482

Conversation

marcodafonseca
Copy link

@marcodafonseca marcodafonseca commented Nov 6, 2020

Added ability to allow developers to change colour palette preset
feat: Customize default colour palette (#481)

feat: #481

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Added ability to allow developers to change colour palette preset

When constructing the ImageEditor a developer can now pass through their own colour palette if they don't want to use the preset one.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@stale
Copy link

stale bot commented Dec 22, 2020

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Dec 22, 2020
@stale
Copy link

stale bot commented Dec 29, 2020

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Dec 29, 2020
@marcodafonseca
Copy link
Author

Is this PR ever going to get some kind of attention or feedback? My clients really need this feature

@JohntheFish
Copy link

I came across this PR because it is functionality I would like to use.
What happens if the initial colour of any tool is not in the palette?
Should the PR also include settings for initial colour of tools?
How would such work with any other tool initialisation options (such options don't exist yet, but maybe could in the future)?

@lja1018 lja1018 reopened this Feb 3, 2021
@stale stale bot removed the inactive label Feb 3, 2021
@lja1018
Copy link
Contributor

lja1018 commented Feb 3, 2021

@marcodafonseca @JohntheFish
Sorry for late reply. We will update as soon as possible.

@stale
Copy link

stale bot commented Mar 5, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Mar 5, 2021
@JohntheFish
Copy link

bump

@stale stale bot removed the inactive label Mar 5, 2021
@stale
Copy link

stale bot commented Apr 7, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Apr 7, 2021
@marcodafonseca
Copy link
Author

+1

@stale stale bot removed the inactive label Apr 7, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Jun 2, 2021
@JohntheFish
Copy link

bump again

@stale stale bot removed the inactive label Jun 2, 2021
@marcodafonseca
Copy link
Author

Bump

@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Jul 8, 2021
@lja1018 lja1018 removed the inactive label Jul 8, 2021
@stale
Copy link

stale bot commented Aug 7, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Aug 7, 2021
@stale
Copy link

stale bot commented Aug 18, 2021

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Aug 18, 2021
@JohntheFish
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants