Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default values for ui-tools (#258) #452

Closed
wants to merge 1 commit into from

Conversation

phwiget
Copy link

@phwiget phwiget commented Sep 16, 2020

override default values for "draw", "shape", "icon" and "text" when used with UI

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

override default values for "draw", "shape", "icon" and "text" when used with UI
@andremonteiro95
Copy link

andremonteiro95 commented Oct 13, 2020

@phwiget maybe you should add some contributors, like @jinwoo-kim-nhn and @junghwan-park, as reviewers of this PR.

@andremonteiro95
Copy link

Can you also add the option for the fill color in the shape class?

@phwiget
Copy link
Author

phwiget commented Oct 13, 2020

Thanks for your suggestion. How can I add reviewers?

@andremonteiro95
Copy link

How can I add reviewers?

Sorry, now that I looked into it I don't think it is possible to add reviewers.

@stale
Copy link

stale bot commented Nov 13, 2020

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Nov 13, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants