add test code job - 1

src/js/imageEditor.js

@@ -303,17 +303,19 @@ class ImageEditor {
  /**
  * RemoveObject Sequential processing for prevent invoke lock
  * @param {Array.<Object>} targetObjects - target Objects for remove
+ * @returns {object} targetObjects
  * @private
  */
  _removeObjectStream(targetObjects) {
  if (targetObjects.length === 0) {
- return;
+ return true;
  }
 
  const targetObject = targetObjects.pop();
- this.removeObject(this._graphics.getObjectId(targetObject)).then(() => {
- this._removeObjectStream(targetObjects);
- });
+
+ return this.removeObject(this._graphics.getObjectId(targetObject)).then(() => (
+ this._removeObjectStream(targetObjects)
+ ));
  }
 
  /**

test/action.spec.js

@@ -112,30 +112,6 @@ describe('Ui', () => {
  });
  });
 
- describe('modeChange()', () => {
- it('_changeActivateMode("TEXT") API should be executed When the modeChange("text") action occurs', () => {
- spyOn(imageEditorMock, '_changeActivateMode');
-
- mainAction.modeChange('text');
- expect(imageEditorMock._changeActivateMode).toHaveBeenCalled();
- });
-
- it('startDrawingMode() API should be executed When the modeChange("crop") action occurs', () => {
- spyOn(imageEditorMock, 'startDrawingMode');
-
- mainAction.modeChange('crop');
- expect(imageEditorMock.startDrawingMode).toHaveBeenCalled();
- });
-
- it('stopDrawingMode(), setDrawingShape(), _changeActivateMode() API should be executed When the modeChange("shape") action occurs', () => {
- spyOn(imageEditorMock, 'setDrawingShape');
- spyOn(imageEditorMock, '_changeActivateMode');
-
- mainAction.modeChange('shape');
- expect(imageEditorMock.setDrawingShape).toHaveBeenCalled();
- expect(imageEditorMock._changeActivateMode).toHaveBeenCalled();
- });
- });
  });
 
  describe('shapeAction', () => {
@@ -341,4 +317,48 @@ describe('Ui', () => {
  expect(imageEditorMock.applyFilter).toHaveBeenCalled();
  });
  });
+
+ describe('commonAction', () => {
+ it('getActions 메소드에 리턴되는 각각의 액션은 commonAction을 포함하고 있어야 한다.', () => {
+ });
+
+ /*
+ describe('modeChange()', () => {
+ it('_changeActivateMode("TEXT") API should be executed When the modeChange("text") action occurs', () => {
+ spyOn(imageEditorMock, '_changeActivateMode');
+
+ mainAction.modeChange('text');
+ expect(imageEditorMock._changeActivateMode).toHaveBeenCalled();
+ });
+
+ it('startDrawingMode() API should be executed When the modeChange("crop") action occurs', () => {
+ spyOn(imageEditorMock, 'startDrawingMode');
+
+ mainAction.modeChange('crop');
+ expect(imageEditorMock.startDrawingMode).toHaveBeenCalled();
+ });
+
+ it('stopDrawingMode(), setDrawingShape(), _changeActivateMode() API should be executed When the modeChange("shape") action occurs', () => {
+ spyOn(imageEditorMock, 'setDrawingShape');
+ spyOn(imageEditorMock, '_changeActivateMode');
+
+ mainAction.modeChange('shape');
+ expect(imageEditorMock.setDrawingShape).toHaveBeenCalled();
+ expect(imageEditorMock._changeActivateMode).toHaveBeenCalled();
+ });
+ });
+ */
+ });
+
+ describe('reAction', () => {
+ /*
+ undoStackChanged
+ redoStackChanged
+ objectActivated
+ addText
+ addObjectAfter
+ objectScaled
+ selectionCleared
+ */
+ });
 });

test/imageEditor.spec.js

@@ -34,5 +34,57 @@ describe('ImageEditor', () => {
 
  expect(snippet.imagePing).not.toHaveBeenCalled();
  });
+
+ it('그룹이 존재할때 removeActiveObject()', () => {
+ spyOn(imageEditor._graphics, 'getActiveGroupObject').and.returnValue({
+ activeObjectGroup: () => [1, 2, 3]
+ });
+ spyOn(imageEditor, '_removeObjectStream');
+ spyOn(imageEditor, 'discardSelection');
+
+ imageEditor = new ImageEditor(el, {
+ usageStatistics: false
+ });
+ imageEditor._reomveActiveObject();
+
+ expect(imageEditor._removeObjectStream).toHaveHeenCalled();
+ });
+ /*
+ it('그룹이 존재하지 않을때 removeActiveObject()', () => {
+ spyOn(imageEditor._graphics, 'getActiveGroupObject').and.returnValue(null);
+ spyOn(imageEditor, '_removeObjectStream');
+ spyOn(imageEditor, 'getActiveObject');
+ //spyOn(imageEditor, 'getActiveObject');
+
+ imageEditor = new ImageEditor(el, {
+ usageStatistics: false
+ });
+ imageEditor._reomveActiveObject();
+
+ expect(imageEditor._removeObjectStream).toHaveHeenCalled();
+ });
+ */
+
+ it('_removeObjectStream()', done => {
+ const promise = new Promise(resolve => {
+ resolve();
+ });
+
+ imageEditor = new ImageEditor(el, {
+ usageStatistics: false
+ });
+
+ spyOn(imageEditor, '_removeObjectStream').and.callThrough();
+ spyOn(imageEditor, 'removeObject').and.returnValue(promise);
+
+ const removeJobsSequens = [1, 2, 3, 4];
+ const removeObjectStremPromise = imageEditor._removeObjectStream(removeJobsSequens);
+ const expected = removeJobsSequens.length + 1;
+
+ removeObjectStremPromise.then(() => {
+ expect(imageEditor._removeObjectStream.calls.count()).toBe(expected);
+ done();
+ });
+ });
  });
 });

test/ui.spec.js

@@ -21,6 +21,13 @@ describe('UI', () => {
  };
  ui = new UI(document.createElement('div'), uiOptions, {});
  });
+ describe('_changeMenu()', () => {
+ it('메뉴가 변경되면 변경되는 메뉴 인스턴스의 changeStartMode()가 실행 되어야 한다.', () => {
+ });
+
+ it('메뉴가 변경되면 기존 메뉴 인스턴스의 changeStandbyMode()가 실행 되어야 한다.', () => {
+ });
+ });
 
  describe('_makeSubMenu()', () => {
  it('MakeMenuElement should be executed for the number of menus specified in the option.', () => {