Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/example page test option #372

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Feat/example page test option #372

merged 3 commits into from
Apr 1, 2020

Conversation

jinwoo-kim-nhn
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. ๐ŸŽ‰ ๐Ÿ˜˜ โœจ

@jinwoo-kim-nhn jinwoo-kim-nhn merged commit 2ba744c into master Apr 1, 2020
jungeun-cho
jungeun-cho reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[04/01] ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

driver.executeScript(`return window.${errorLogVariable}`);

errorLogVariable์ด false๊ฐ’์ด ๋ฐ˜ํ™˜๋  ์ˆ˜๋„ ์žˆ๋Š”๋ฐ ํ™•์ธ๋ถ€ํƒ๋“œ๋ ค์š”.

exampleTest.js Outdated
@@ -96,7 +101,7 @@ async function testPlatform(platformInfo, urls) {
, DOCUMENT_LOAD_MAX_TIMEOUT);

const browserInfo = await driver.getCapabilities();
const errorLogs = await driver.executeScript('return window.errorLogs');
const errorLogs = await driver.executeScript(`return window.${errorLogVariable}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getGlobalErrorLogVariable()์—์„œ false๊ฐ’์ด ๋ฐ˜ํ™˜๋  ์ˆ˜ ๋„์žˆ์Šต๋‹ˆ๋‹ค.
ํ™•์ธ๋ถ€ํƒ๋“œ๋ ค์š”.

Copy link
Contributor Author

@jinwoo-kim-nhn jinwoo-kim-nhn Apr 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ใ… ใ…  ์•„ ๊ทธ๋ ‡๋„ค์š”;; ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ํฐ์ผ๋‚ ๋ป” ํ–ˆ๋„ค์š”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

globalErrorLogVariable ๊ฐ’์ด ์œ ํšจํ•œ ๊ฒฝ์šฐ์—๋งŒ ์Šคํฌ๋ฆฝํŠธ๋ฅผ ์‹คํ–‰ํ•  ์ˆ˜ ์žˆ๋„๋ก ์ฒ˜๋ฆฌํ•˜๋Š”๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
์ œ ์ƒ๊ฐ์—๋Š” testPlatform ํ•จ์ˆ˜๊ฐ€ ํ˜ธ์ถœ๋˜๊ธฐ ์ „์— ์ฒดํฌํ•˜๋Š”๊ฒŒ ๋งž์„ ๊ฒƒ ๊ฐ™์•„์š”.
globalErrorLogVariable ์˜ต์…˜ ๊ฐ’์ด false์ธ๋ฐ ์Šคํฌ๋ฆฝํŠธ๋ฅผ ์‹คํ–‰ํ•˜๋Š”๊ฒŒ ์˜๋ฏธ๊ฐ€ ์—†์–ด๋ณด์—ฌ์„œ์š”ใ…Ž

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์„ ์ž„์„ ์ž„๋‹˜ ์˜๊ฒฌ์ด ์ •๋‹ต์ด๋„ค์š”. ๋ฐ”๋กœ ๋ฐ˜์˜ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@jungeun-cho
Copy link
Contributor

์• ํ”Œ๋ฆฌ์ผ€์ด์…˜ ์ ์šฉ ๊ฐ€์ด๋“œ๊ฐ€ ์žˆ์œผ๋ฉด ํ™•์ธํ•ด๋ณผ ์ˆ˜ ์žˆ์„๊นŒ์š”?

  • tui-doc ๋ฒ„์ „ ์—…๋ฐ์ดํŠธ
  • doc config ์ˆ˜์ •
  • exampleTest.js ํŒŒ์ผ ์ถ”๊ฐ€

์ด๋ ‡๊ฒŒ ์ž‘์—…ํ•˜๋ฉด๋˜๋‚˜์š”?~

@jinwoo-kim-nhn
Copy link
Contributor Author

@jungeun-cho ๋‚ด์ผ ์Šคํฌ๋Ÿผ๋•Œ ๊ณต์œ ํ• ๋ ค๊ณ  ํ–ˆ๋Š”๋ฐ ๋ฏธ๋ฆฌ url ์•Œ๋ ค๋“œ๋ฆด๊ป˜์š”

@jung-han
Copy link
Member

jung-han commented Apr 2, 2020

๋ฆฌ๋ทฐ ์™„๋ฃŒ์ž…๋‹ˆ๋‹ค~

seonim-ryu
seonim-ryu reviewed Apr 2, 2020
View reviewed changes
tuidoc.config.json Outdated
@@ -31,7 +31,8 @@
"example01-includeUi": "1. Include ui",
"example02-useApiDirect": "2. Use api direct (basic)",
"example03-mobile": "3. Mobile"
}
},
"globalErrorLogVariable": "errorLogs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"globalErrorLogVariable": true๋กœ ํ•ด๋„ ๋˜์ง€ ์•Š์„๊นŒ์š”?ใ…Ž ์•„๋‹ˆ๋ฉด ์˜ˆ์ œ๋กœ ์‚ฌ์šฉํ•˜์‹ ๊ฑด๊ฐ€์š”??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true๋กœ ํ•˜๋ฉด ๋˜๊ฒ ๋„ค์š”ใ…Žใ…Ž ๋ฆฌ๋ทฐ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.

@seonim-ryu
Copy link
Member

[4/2] ๋ฆฌ๋ทฐ ์™„๋ฃŒํ•ฉ๋‹ˆ๋‹ค. ๊ณ ์ƒ ๋งŽ์œผ์…จ์–ด์š”~

@jinwoo-kim-nhn
Copy link
Contributor Author

jinwoo-kim-nhn commented Apr 2, 2020 •
edited
Loading

apply review #373

HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@jinwoo-kim-nhn @HerlinMatos
Feat/example page test option (nhn#372)
166480d 
* change option globalErrorLogVariable

* some refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seonim-ryu seonim-ryu seonim-ryu left review comments

@jungeun-cho jungeun-cho jungeun-cho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jinwoo-kim-nhn @jungeun-cho @jung-han @seonim-ryu