fix: group object delete after restore position (fix #356) #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Mar 31, 2020
test/graphics.spec.js
Outdated
| const removeGroupObjectId = graphics.getActiveObjectIdForRemove(); | ||
| const removeGroupObject = graphics.getObject(removeGroupObjectId); | ||
|
|
||
| expect(removeGroupObject.left).toBe(5); |
There was a problem hiding this comment.
undo 했을 때 포지션 정보가 잘 나오는지 검증이 되나요?
There was a problem hiding this comment.
테스트를 좀 보강해보겠습니다. 리뷰 감사합니다.ㅎㅎ
|
[03/31] 리뷰 완료합니다. |
jinwoo-kim-nhn
changed the title
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* fix: group object delete after restore position * apply codereview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)버그
다중 선택된 객체들을 백스페이스로 삭제 후 되돌리기(undo) 를 했을때 되돌려진 객체의 포지션이 정확하지 않음
버그원인
graphics.getActiveObjectIdForRemove에서 멀티셀렉트된 객체들을 한번에 삭제하기위해 group을 만들어줄때 group의 포지션을 모름으로, 되돌릴때 x, y (0, 0)의 잘못된 포지션으로 되돌려줌해결방법
삭제를 위한 group을 만들때 삭제되기 전의 오리지날 포지션을 정확히 넣어줌
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨