Feat/core js with esmodule #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghwan-park
approved these changes
Mar 11, 2020
dongsik-yoo
reviewed
Mar 13, 2020
src/js/command/addShape.js
Outdated
| @@ -3,10 +3,9 @@ | |||
| * @fileoverview Add a shape | |||
| */ | |||
| import commandFactory from '../factory/command'; | |||
| import Promise from 'core-js/library/es6/promise'; | |||
| import consts from '../consts'; | |||
| import Promise from 'core-js-pure/features/promise'; | |||
There was a problem hiding this comment.
Promise를 관리하는 모듈을 만들어서 리턴하는 건 어떠세요? 추후에 라이브러리 변경이나 폴더 경로 변경이 있을 때도 수정이 간편할 것 같아요.
There was a problem hiding this comment.
네 수정이 잦으면 귀찮을것 같으니.. 좋은 방법 같네요. Promise를 리턴해주는 유틸함수를 만들어서 처리해보겠습니다.
dongsik-yoo
reviewed
Mar 13, 2020
src/js/component/shape.js
Outdated
| import Component from '../interface/component'; | ||
| import consts from '../consts'; | ||
| import {rejectMessages, eventNames, keyCodes as KEY_CODES, componentNames, fObjectOptions, SHAPE_DEFAULT_OPTIONS} from '../consts'; |
There was a problem hiding this comment.
prettier 쓰나요?
아니면 임포트 한개당 개행 하나가 어떨까요? 가로로 너무 길지 않은가 해서요.
There was a problem hiding this comment.
넵 반영하겠습니다. 감사합니다.
dongsik-yoo
reviewed
Mar 13, 2020
| @@ -321,8 +321,8 @@ class Ui { | |||
| _makeMenuPartitionElement() { | |||
| const partitionElement = document.createElement('li'); | |||
| const partitionInnerElement = document.createElement('div'); | |||
| partitionElement.className = util.cls('item'); | |||
| partitionInnerElement.className = util.cls('icpartition'); | |||
| partitionElement.className = cls('item'); | |||
There was a problem hiding this comment.
저번 리뷰에서, 일부 적용했었어요 ㅎㅎ
dongsik-yoo
reviewed
Mar 13, 2020
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* feat: babel version up with change module system esmodule * feat: enable useBuiltIns option of bable7 * fix: fixed config middle commit * feat: update corejs with esmodule syntax * apply codereview * apply codereview - 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨