Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cropzone default option change (fix #101) #349

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

jinwoo-kim-nhn
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

작업내용

  • 크롭존에 수평기울이기, 수직기울이기 옵션이 허용되어 있어서 크롭존이 찌그러지는 경우가 발생
  • DEFAULT 옵션을 정의하여 찌그러지지 않도록 옵션 설정

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[03/09] 이견없습니다. 수고하셨습니다.

Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 :)

@jinwoo-kim-nhn jinwoo-kim-nhn changed the title feat: cropzone default option change feat: cropzone default option change (fix #101) Mar 10, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn merged commit 6ddd1d2 into master Mar 10, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn deleted the fix/cropzoneDefaultOptionChange branch March 20, 2020 08:12
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants