chore: document for svg icon setting #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Mar 4, 2020
docs/Basic-Tutorial.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| 2. There is a way to use the **actual physical svg file** and **set the file location manually**. |
There was a problem hiding this comment.
actual physical svg file는 그냥 your svg file정도면 되지 않을까요?
There was a problem hiding this comment.
네 정확하게 표현하고 싶어서 작업 하다보니 과했던거 같네요.. 반영하겠습니다.
dongsik-yoo
reviewed
Mar 4, 2020
docs/Basic-Tutorial.md
Outdated
| * The disadvantage is that the color must be set by modifying the svg file directly. | ||
| * Need to set the path and name for each icon state as shown below. | ||
| ```js | ||
| var instance = new ImageEditor(document.querySelector('#tui-image-editor'), { |
There was a problem hiding this comment.
반영하였습니다. 리뷰 감사합니다.
dongsik-yoo
reviewed
Mar 4, 2020
src/js/ui/theme/standard.js
Outdated
| 'submenu.normalIcon.color': '#8a8a8a', | ||
| 'submenu.activeIcon.color': '#e9e9e9', | ||
|
|
||
| // icons (svg icon file setting) |
There was a problem hiding this comment.
유저한테 다른 형식으로 사용할수 있다는걸 알려주려고 했는데, 어색한것 같네요. 문서에 충분히 설명을 했으니 빼버리겠습니다.
dongsik-yoo
reviewed
Mar 4, 2020
docs/Basic-Tutorial.md
Outdated
| ... | ||
| }); | ||
| ``` | ||
| * How to get svg file sample |
There was a problem hiding this comment.
svg를 대문자로 쓰면 어떨까요?
-
How to get svg file sample
-
How to get SVG file sample
There was a problem hiding this comment.
넵 좋네요 ㅎㅎ svg 쓰인부분 일괄 반영하겠습니다.
junghwan-park
approved these changes
Mar 5, 2020
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* feat: default menu svg icon - middle commit * feat: default icon normal Check basic operation * feat: prototype complete for default icon improve * feat: complate default icon code * example file update for default icon setting * chore: svg-loader dependency -> devdependency * chore: document for svg icon setting * fixed some link at document * apply codereview * apply codereview - 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description