refactor: silentUndoCache #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoo-kim-nhn
changed the base branch from
master
to
feat/undoRedoForSliderFilter
| setUndoData(undoData, chchedUndoDataForSilent, isSilent) { | ||
| if (chchedUndoDataForSilent) { | ||
| undoData = chchedUndoDataForSilent; | ||
| } |
There was a problem hiding this comment.
이 if문이 있어야 할까요? 아래에서 undoData를 쓸 때 삼항연산자로 표현하면 더 깔끔할거 같습니다.
snippet.extend(this.undoData, chchedUndoDataForSilent ? chchedUndoDataForSilent : undoData);There was a problem hiding this comment.
그렇군요.. 넵. 반영하겠습니다.
There was a problem hiding this comment.
아;; 다시보니 바로 아래 부분에서 !isSilent가 아닐때 변경된 undoData를 써야되기때문에 아래로 빼면 안될것 같네요.
src/js/interface/command.js
Outdated
| * @param {boolean} isSilent - is silent execution or not | ||
| * @returns {Object} chchedUndoDataForSilent | ||
| */ | ||
| setUndoData(undoData, chchedUndoDataForSilent, isSilent) { |
There was a problem hiding this comment.
아;; 오타네요 수정하겠습니다. 감사합니다.
jinwoo-kim-nhn
changed the base branch from
feat/undoRedoForSliderFilter
to
master
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* feat: slider undo redo for filter - middle commit * middle commit * feat: prototype complete * fix: added test and refactoring * refactor: add jsdoc with filter typename map * refactor: isSilent for cacheUndodata * refactor: abstract for chache undo data * refactor: set undodate with cache for silent command * refactor: change static variable for cached undoData * apply codereview Co-authored-by: superlucky84 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isSilent command를 위한 undoData를 캐시하는 방식 리팩토링
이전 PR에서 의논된 부분의 개선입니다.
문제점
개선