feat: add object rotated event listener #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoo-kim-nhn
changed the title
jinwoo-kim-nhn
changed the title
dongsik-yoo
reviewed
Feb 12, 2020
| 'selectionCleared': this._handlers.selectionCleared, | ||
| 'selectionCreated': this._handlers.selectionCreated, | ||
| 'addObjectAfter': this._handlers.addObjectAfter | ||
| [MOUSE_DOWN]: this._handlers.mousedown, |
dongsik-yoo
reviewed
Feb 12, 2020
src/js/imageEditor.js
Outdated
| */ | ||
| _onObjectRotated(props) { | ||
| /** | ||
| * The event when scale factor is changed |
There was a problem hiding this comment.
복붙 걸렸네요 ;; 수정하였습니다. ㅎㅎ
dongsik-yoo
reviewed
Feb 12, 2020
test/imageEditor.spec.js
Outdated
|
|
||
| canvas.fire('object:rotating', mock); | ||
|
|
||
| expect(imageEditor.fire.calls.mostRecent().args[0]).toBe('objectRotated'); |
There was a problem hiding this comment.
테스트 코드에도 OBJECT_ROTATED 쓰면 되겠어요.
There was a problem hiding this comment.
반영하였습니다. 감사합니다.
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* middle commit * feat: added object rotate event * unnessary line delete * apply code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
issue
작업내용