Feat/cropzone fix ratio #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Feb 7, 2020
src/js/component/cropper.js
Outdated
| @@ -97,6 +98,7 @@ class Cropper extends Component { | |||
| lockScalingFlip: true, | |||
| lockRotation: true | |||
| }, this.graphics.cropSelectionStyle); | |||
| // this._cropzone.lockUniScaling = true; | |||
There was a problem hiding this comment.
넵 제거하겠습니다. 감사합니다.
src/js/extension/cropzone.js
Outdated
| * @returns {{width: number, height: number}} | ||
| * @private | ||
| */ | ||
| _cornerTypeValid(selectedCorner) { |
There was a problem hiding this comment.
이런 함수는 this를 사용하지 않으니 독립적인 함수로 존재하면 깔끔할 것 같아요. 클래스의 다른 함수들도 그런 모습들이 있네요.
그리고 약간 미세 튜닝 같긴 하지만, 함수 내의 배열은 모듈 로딩할 때 한번만 만드는 것이 어떨까 합니다.
src/js/extension/cropzone.js
Outdated
| * @private | ||
| */ | ||
| _resizeTL({x, y}) { | ||
| const rect = this.getBoundingRect(false, true); |
There was a problem hiding this comment.
이 경우는 destructuring 쓰는게 코드가 좀 더 작지 않을까요?
There was a problem hiding this comment.
넵 그럴것 같네요 반영하겠습니다.
| * @private | ||
| */ | ||
| _calcTopLeftScalingSizeFromPointer(x, y) { | ||
| _resizeMT({y}) { |
There was a problem hiding this comment.
_resize~~~ 메소드에 비슷한 패턴의 코드가 중복인 것 같은데요, 공통 부분을 추출할 수 있을까요?
There was a problem hiding this comment.
공통인 부분을 최대한 추출해여 고쳐보도록 하겠습니다. 감사합니다.
|
중복패턴 제거 작업을 #327 에서 마저 작업함 |
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* middle commit * feat: cropzone resizer prototype complete * refactor: jsdoc with code style changed * feat: cropzone preset ratio complete * apply codereview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
issue
작업내용
비율 고정시에는 드레그 마우스 포인터와 리사이즈 컨트롤 위치에 따른 리사이즈 비율의 너비 , 높이 기준점을 정하기 위해서 8개 방위의 리사이즈 컨트롤 별로 계산식이 존재 해야되기 때문에, 기존 방식을 버리고 더 접근하기 쉬운 방식으로 8개의 방위별로 각각 dimension을 구하는 방식으로 변경