fix: fixed exist cropzone bug in toDataUrl image (fix #237 #224) #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….image-editor into feat/devConfigToolUpdate
jinwoo-kim-nhn
changed the title
jinwoo-kim-nhn
changed the title
jinwoo-kim-nhn
changed the title
junghwan-park
approved these changes
Jan 17, 2020
dongsik-yoo
reviewed
Jan 17, 2020
src/js/component/cropper.js
Outdated
| * Change cropzone visible | ||
| * @param {boolean} visible - cropzone visible state | ||
| */ | ||
| changeVisible(visible) { |
There was a problem hiding this comment.
I think this method name should be changeVisibility.
There was a problem hiding this comment.
네 이게 더 적확한 표현 같네요. 반영하겠습니다.
src/js/component/cropper.js
Outdated
| * @param {boolean} visible - cropzone visible state | ||
| */ | ||
| changeVisible(visible) { | ||
| const cropzone = this._cropzone; |
There was a problem hiding this comment.
There is this simple version implementation.
this._cropzone && this._cropzone.set({visible});There was a problem hiding this comment.
넵 이렇게 하면 간결해지겠네요. ㅎㅎ 감사합니다
jinwoo-kim-nhn
changed the base branch from
feat/devConfigToolUpdate
to
master
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
nhn#300) * feat: webpack version up * feat: cssExtract plugin update * feat: karma.conf update middle commit * feat: karma.conf update middle commit * feat: webpack with karma version update middle commit * update package-lock * feat: karma version update 4.x.x * fix: fixed all vulnerabilities at package.json * fix: added mode property webpack config * feat: added dist directory for npm istall test * test complete with delete dist directory * restore un nessary fix point * apply code review at webpack config * fix: fixed fabricjs install guide * fix: fix karma.conf.js for css-loader webpack config * fix: fixed exist cropzone bug in toDataUrl image * apply code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
issue
해결
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨