Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed shape resize bug (fix #297) #296

Merged
merged 13 commits into from
Jan 15, 2020
Merged

fix: fixed shape resize bug (fix #297) #296

merged 13 commits into from
Jan 15, 2020

Conversation

jinwoo-kim-nhn
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn commented Jan 13, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

issue

* https://github.com/nhn/tui.image-editor/issues/297

원인

  1. 드래그 시작시 origin에 따라 포지션을 구하는 공식에 오타로 인한 버그가 있음
  2. 드래그 도중 포지션을 정렬 해주는 함수에서 포지션을 되 잡아주지만 origin을 변경하고도 fabric사용법대로 shape.setCoords(); 를 실행 안해주고 있으므로 정상 동작을 보장하지 않음

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jinwoo-kim-nhn jinwoo-kim-nhn changed the title fix: fixed shape resize bug fix: fixed shape resize bug (fix #297) Jan 14, 2020
junghwan-park
junghwan-park approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다!

dongsik-yoo
dongsik-yoo reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[01/14] Reviewed. Good job!

@jinwoo-kim-nhn jinwoo-kim-nhn changed the base branch from feat/devConfigToolUpdate to master January 15, 2020 06:23
@jinwoo-kim-nhn jinwoo-kim-nhn merged commit c166a55 into master Jan 15, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn deleted the fix/shapeRenderAtAddWithResize branch March 20, 2020 08:13
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@jinwoo-kim-nhn @HerlinMatos
fix: fixed shape resize bug (fix nhn#297) (nhn#296)
f9cf7f6 
* feat: webpack version up

* feat: cssExtract plugin update

* feat: karma.conf update middle commit

* feat: karma.conf update middle commit

* feat: webpack with karma version update middle commit

* update package-lock

* feat: karma version update 4.x.x

* fix: fixed all vulnerabilities at package.json

* fix: added mode property webpack config

* feat: added dist directory for npm istall test

* test complete with delete dist directory

* fix: fixed shape resize bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsik-yoo dongsik-yoo dongsik-yoo left review comments

@junghwan-park junghwan-park junghwan-park approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jinwoo-kim-nhn @junghwan-park @dongsik-yoo