Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

放大缩小功能 #287

Closed
wants to merge 1 commit into from
Closed

放大缩小功能 #287

wants to merge 1 commit into from

Conversation

Dolov
Copy link

@Dolov Dolov commented Dec 17, 2019

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@junghwan-park
Copy link
Member

@Dolov
Could you translate this issue to english?
I can't understand your language and your code change means.

@@ -33,7 +33,7 @@
},
theme: blackTheme, // or whiteTheme
initMenu: 'filter',
menuBarPosition: 'bottom'
menuBarPosition: 'left'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should revert position value to 'bottom'.

@@ -98,7 +98,7 @@ body > textarea
position: absolute;
bottom: 0;
width: 100%;
overflow: auto;
overflow: hidden;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this overflow has changed?
Any reason?

@zhangruinian
Copy link

我觉得 你写的不错, 基础放大缩小可以用, 再加个拖动完美了

@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Apr 2, 2020
@stale
Copy link

stale bot commented Apr 9, 2020

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants