Fix/multi instance behavior #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Dec 3, 2019
| apply: this.selector('#tie-crop-button .apply'), | ||
| cancel: this.selector('#tie-crop-button .cancel'), | ||
| preset: this.selector('#tie-crop-preset-button') | ||
| apply: this.selector('.tie-crop-button .apply'), |
There was a problem hiding this comment.
이건 딴 얘긴데요, this.selector는 왜 프로토타입에 안 넣고 생성자에서 매번 만들었을까요?ㅎ
There was a problem hiding this comment.
아;; 지금보니까 그렇네요 이것도 함께 수정해보겠습니다. 감사합니다.
|
노가다 좀 하셨네요. 고생 많으셨습니다. |
HerlinMatos
pushed a commit
to EveryMundo/tui.image-editor
that referenced
this pull request
Jul 2, 2020
* fix: filter checkbox behavior bug for filter * fix: Replace all identity identifiers with class identifiers. for instance behavior * fix: restore test example * feat: apply code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현상
버그 원인
버그 수정