Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve text underline issue (fix: #221) #225

Merged
merged 3 commits into from
Jan 10, 2020
Merged

fix: Resolve text underline issue (fix: #221) #225

merged 3 commits into from
Jan 10, 2020

Conversation

junghwan-park
Copy link
Member

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@junghwan-park junghwan-park added this to the v3.8.0 milestone Aug 5, 2019
@jwehrman
Copy link
Contributor

looks good, verified locally.

@jwehrman jwehrman mentioned this pull request Oct 31, 2019
Merged
7 tasks
@jinwoo-kim-nhn jinwoo-kim-nhn merged commit 549c232 into master Jan 10, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn removed this from the v3.8.0 milestone Jan 23, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn deleted the fix/underline-issue branch March 20, 2020 08:13
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@junghwan-park @jinwoo-kim-nhn @HerlinMatos
fix: Resolve text underline issue (fix: nhn#221) (nhn#225)
92e1d3a 
* fix: Resolve text underline issue

* fix: Resolve text underline issue in API direct example

Co-authored-by: 김진우 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text underline not working with 3.6.0
3 participants
@junghwan-park @jwehrman @jinwoo-kim-nhn