Branch v3.5.3 #215
Branch v3.5.3 #215
Conversation
# Conflicts: # index.d.ts
There was a problem hiding this comment.
Thank you for contribution. @lewis-ing
But, some conventions are violated. I can't merge it into master branch.
- Specify category and title it what your develop.
- ex)
feature: Add 'mouseUp' event listeners, orfix: Resolve free-draw lines jumping
- ex)
- Write an issue and describe what to do for this PR.
- Read and follow PR template's guideline.
masterbranch must not be includesdist/directory. It is only served inproductionbranch.
|
|
||
| B: x=开始坐标X y=开始坐标Y+结束坐标Y | ||
|
|
||
| C: x=开始坐标X+结束坐标X y=开始坐标Y+结束坐标Y |
There was a problem hiding this comment.
Please, Translate Chinese texts in English.
| @@ -21,6 +21,7 @@ module.exports = { | |||
| 'prefer-destructuring': ['error', { | |||
| VariableDeclarator: {array: true, object: true}, | |||
| AssignmentExpression: {array: false, object: false} | |||
| }] | |||
| }], | |||
| 'linebreak-style': 'off' | |||
There was a problem hiding this comment.
I think this rule is useful. Why are you turn off linebreak-style?
| @@ -54,5 +54,3 @@ report | |||
| *.vim | |||
| test.html | |||
|
|
|||
| # Compiled files | |||
| dist | |||
There was a problem hiding this comment.
This addition is violating repository's branch managing convention.
We're not use develop branch but, master branch take develop branch's act.
Distribution files must be served in production branch.
| @@ -15,15 +15,15 @@ | |||
| </head> | |||
| <body> | |||
|
|
|||
| <button onclick="test()"></button> | |||
|
|
|||
There was a problem hiding this comment.
Testing codes must be removed.
| // if(fEvent.e.movementX == -1 && fEvent.e.movementY == -1){ | ||
| // console.log(this._fEvent) | ||
| // } | ||
| //console.log(this._fEvent) |
There was a problem hiding this comment.
This file contains all the prototype codes.
console.log()s are must be removed too.
| @@ -64,6 +64,7 @@ | |||
| "test:ne": "KARMA_SERVER=ne karma start", | |||
| "test:types": "tsc --project test/types", | |||
| "bundle": "webpack && webpack -p && npm run bundle:svg && node tsBannerGenerator.js", | |||
| "product": "webpack -p && npm run bundle:svg && node tsBannerGenerator.js", | |||
There was a problem hiding this comment.
I think this command script already defined upper line 66.
| @@ -945,12 +958,15 @@ class Graphics { | |||
| * "object:moving" canvas event handler | |||
| * @param {{target: fabric.Object, e: MouseEvent}} fEvent - Fabric event | |||
| * @private | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Closing line comment text is removed.
| 'submenu.normalIcon.name': 'icon-a', | ||
| 'submenu.activeIcon.path': '../dist/svg/icon-c.svg', | ||
| 'submenu.activeIcon.path': '../static/svg/icon-c.svg', |
There was a problem hiding this comment.
Why did you edit default image paths?
|
thank you. The delay period is too long to close without modification. Make a new contribution through the master branch. |
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨