Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Initialize UI defaultIcons without initial selected menu option. (fix #115) #127

Merged
merged 1 commit into from
Jan 18, 2019
Merged

fix: Initialize UI defaultIcons without initial selected menu option. (fix #115) #127

merged 1 commit into from
Jan 18, 2019

Conversation

junghwan-park
Copy link
Member

@junghwan-park junghwan-park commented Jan 18, 2019 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Issue: #115

Bug fix

  • Initialize and register default icon sets regardless initMenu option's value
  • Add button svg for icon-start-2

Chore

  • Correct mistyped JSDoc parameter types

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@junghwan-park junghwan-park self-assigned this Jan 18, 2019
jinwoo-kim-nhn
jinwoo-kim-nhn approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@jinwoo-kim-nhn jinwoo-kim-nhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이견 없습니다. 수고하셨습니다.

dongsik-yoo
dongsik-yoo approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@dongsik-yoo dongsik-yoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[01/18] 수고 많으셨습니다. 별다른 사항 없습니다.

@junghwan-park junghwan-park merged commit 4be0e6b into master Jan 18, 2019
@junghwan-park junghwan-park deleted the fix/default-icon-initialization branch January 18, 2019 03:17
@junghwan-park junghwan-park added this to the v3.5.0 milestone Feb 13, 2019
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@junghwan-park @HerlinMatos
fix: Initialize UI defaultIcons without initial selected menu option. (…
2d739ef 
…nhn#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsik-yoo dongsik-yoo dongsik-yoo approved these changes

@jinwoo-kim-nhn jinwoo-kim-nhn jinwoo-kim-nhn approved these changes

Assignees

@junghwan-park junghwan-park

Labels
Bug
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@junghwan-park @dongsik-yoo @jinwoo-kim-nhn