Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove jQuery type #122

Merged
merged 2 commits into from
Feb 13, 2019
Merged

chore: Remove jQuery type #122

merged 2 commits into from
Feb 13, 2019

Conversation

jungeun-cho
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • chore: remove jquery type

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@junghwan-park junghwan-park changed the title chore: remove jquery type chore: Remove jQuery type Jan 18, 2019
junghwan-park
junghwan-park approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@junghwan-park junghwan-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[02/13] 리뷰 완료했습니다.

@junghwan-park junghwan-park merged commit dc747f8 into master Feb 13, 2019
@junghwan-park junghwan-park deleted the chore/remove-jquery-type branch February 13, 2019 01:54
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
@jungeun-cho @HerlinMatos
chore: Remove jQuery type (nhn#122)
61123a1 
* chore: remove jquery type

* chore: fix d.ts version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junghwan-park junghwan-park junghwan-park approved these changes

@jinwoo-kim-nhn jinwoo-kim-nhn Awaiting requested review from jinwoo-kim-nhn

Assignees

@jungeun-cho jungeun-cho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jungeun-cho @junghwan-park