feat: Localization feature was added #45 #107
Conversation
|
Can one of the admins verify this patch? |
|
@junghwan-park |
|
oh, there was a deployment of a service on this week. Thanks for your effort and PRs. We'll review them soon. |
src/js/ui/locale/locale.js
Outdated
| * @returns {string} | ||
| */ | ||
| localize(message) { | ||
| return (this._locale[message]) ? this._locale[message] : message; |
There was a problem hiding this comment.
Is this parenthesis necessary? I think it's better using short-circuit evaluation than conditional ternary operator.
return this._locale[message] || message;There was a problem hiding this comment.
@dongsik-yoo, It is a good idea. I was refactored it.
| @@ -247,12 +247,18 @@ Add dependencies & initialize ImageEditor class with given element to make an im | |||
| ```javascript | |||
| var ImageEditor = require('tui-image-editor'); | |||
| var blackTheme = require('./js/theme/black-theme.js'); | |||
| var locale_ru = { // override default English locale to your custom | |||
There was a problem hiding this comment.
I think we need a document of a full key list. How about /docs/Basic-Tutorial.md?
@jinwoo-kim-nhn Any idea?
There was a problem hiding this comment.
@dongsik-yoo, I will make doc today.
…rnary operator
|
The documentation issue is on #110 . |
Description
Localization feature was added. Please, let me know if I need to change something into my PR.
Maybe tests should be added.
Also, maybe this feature must to change current npm version of tui.image-editor.
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨