We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadImageFromURL
Describe the bug The loadImageFromURL method's type suggests that the second parameter (imageName) is optional, but it's required.
imageName
To Reproduce Just use the method and look that TS doesn't complain when we don't pass imageName. If you run the application, it logs an error.
Here, we can see that the function rejects a Promise if imageName is falsy.
tui.image-editor/apps/image-editor/src/js/imageEditor.js
Lines 751 to 754 in 9ee993e
Expected behavior The imageName parameter in the loadImageFromURL definition is marked as required.
The text was updated successfully, but these errors were encountered:
fix: mark the imageName parameter in the loadImageFromURL type defini…
0843fee
…tion as required (fix nhn#842)
No branches or pull requests
Describe the bug
The
loadImageFromURL
method's type suggests that the second parameter (imageName
) is optional, but it's required.To Reproduce
Just use the method and look that TS doesn't complain when we don't pass
imageName
. If you run the application, it logs an error.Here, we can see that the function rejects a Promise if
imageName
is falsy.tui.image-editor/apps/image-editor/src/js/imageEditor.js
Lines 751 to 754 in 9ee993e
Expected behavior
The
imageName
parameter in theloadImageFromURL
definition is marked as required.The text was updated successfully, but these errors were encountered: