Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] iterationCount argument missing in redo/undo #795

Closed
LeakAGeek opened this issue Aug 5, 2022 · 1 comment
Closed

[TypeScript] iterationCount argument missing in redo/undo #795

LeakAGeek opened this issue Aug 5, 2022 · 1 comment
Labels
Bug

Comments

@LeakAGeek
Copy link
Contributor

LeakAGeek commented Aug 5, 2022 •
edited
Loading

Describe the bug

Type in index.d.ts:
public redo(): Promise;
public undo(): Promise;

Should be:
public redo(iterationCount: number): Promise;
public undo(iterationCount: number): Promise;

API:
image
image
@LeakAGeek LeakAGeek added the Bug label Aug 5, 2022
@LeakAGeek LeakAGeek changed the title [TypeScript] iterationCount argument missing in undo [TypeScript] iterationCount argument missing in redo/undo Aug 5, 2022
LeakAGeek pushed a commit to LeakAGeek/tui.image-editor that referenced this issue Aug 6, 2022
fix: iterationCount redo/undo (fixed nhn#795)
b10ba49
@lja1018
Copy link
Contributor

lja1018 commented Sep 8, 2022

@LeakAGeek
Thank you for the missing type report. PR will be reviewed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lja1018 @LeakAGeek