Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fabric dependency from ^4.2.0 to ^5.2.1 (latest) #770

Open
ajssd opened this issue May 2, 2022 · 4 comments
Open

Bump fabric dependency from ^4.2.0 to ^5.2.1 (latest) #770

ajssd opened this issue May 2, 2022 · 4 comments
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation

Comments

@ajssd
Copy link

ajssd commented May 2, 2022

Please bump the "fabric" dependency from ^4.2.0 to ^5.2.1 (latest).

Fabric v4 relies on an old version of JSDOM, which in turn has dependencies on unsupported packages like request.js and its various dependencies in turn.
@ajssd ajssd added Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation labels May 2, 2022
@lja1018
Copy link
Contributor

lja1018 commented May 4, 2022

@ajssd
Thank you for your suggestion. I'll update it.

@mroest
Copy link

mroest commented Jun 23, 2022

Can this be updated? JSON has a security vulnerability See: GHSA-f4c9-cqv8-9v98

@aterlamia
Copy link

aterlamia commented Jun 24, 2022 •
edited
Loading

Yeah could be great if this could be updated as adding a resolution in my for jsdom package.json does not work because of back ward compatibility issues. However with a resolution to fabric 5.2.1 everything still seems to work. SO that gives hope this is only a small change

@lja1018
Copy link
Contributor

lja1018 commented Jul 14, 2022

@mroest @aterlamia
There are no updates yet. I'm sorry.
I understand the need for updates. But I don't have enough time. 😢

antonaavik pushed a commit to antonaavik/tui.image-editor that referenced this issue Sep 17, 2022
@antonrush
feat: update fabric version to 5.2.4 nhn#770
889f2ce
antonaavik pushed a commit to antonaavik/tui.image-editor that referenced this issue Sep 21, 2022
@antonrush
feat: update fabric version to 5.2.4 nhn#770
0f7bd6d
@antonaavik antonaavik mentioned this issue Sep 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aterlamia @mroest @ajssd @lja1018