Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'SPACE' key does not work in the entire application when we load vue toast UI image editor component #560

Open
ganesh-500 opened this issue Mar 22, 2021 · 5 comments
Labels

Comments

@ganesh-500
Copy link

We are using vue-image-editor component for selecting media.
Once we open/load the component, we are not able to use the space bar further in the entire application. We are facing below error :

tui-image-editor.js?abe2:16809 Uncaught TypeError: Cannot read property 'fire' of null
at klass.eval (tui-image-editor.js?abe2:16809)
at klass.fire (fabric.js?2f75:313)
at Zoom.startHandMode (tui-image-editor.js?abe2:9480)
at Zoom._onKeyDown (tui-image-editor.js?abe2:9352)

Observations on debugging the issue

  1. For image editor instance , When we open the component an event listener is being added for keyup/keydown and while closing the component the evemt listemer is being removed.
  2. On loading the component , for keyup and keydown events there is an evemt listener being added at Zoomclass. But onclosing the component here the event listener is not being removed.

Images will be added below :
event listener for zoom class

Getting the error as shown in the image in the console :
console error

@ganesh-500 ganesh-500 added the Bug label Mar 22, 2021
@JohntheFish
Copy link

I am seeing the same bug. keyup/keydown listener is hogging the space key after the image editor is closed and destroyed.

@bilalmalkoc
Copy link

Same. Please fix that.

@lja1018
Copy link
Contributor

lja1018 commented Mar 24, 2021

@ganesh-500 @JohntheFish @bilalmalkoc
Thank you for the information. I'll fix it ASAP.

@lja1018
Copy link
Contributor

lja1018 commented Mar 25, 2021

@ganesh-500 @JohntheFish @bilalmalkoc
Resolved in v3.14.2. Thank you :)

@ganesh-500
Copy link
Author

Working fine now. Thank you @lja1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants