Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Editor crop function breaks in Safari v14 #461

Closed
parrywh opened this issue Oct 3, 2020 · 5 comments
Closed

Image Editor crop function breaks in Safari v14 #461

parrywh opened this issue Oct 3, 2020 · 5 comments
Labels
Bug

Comments

@parrywh
Copy link

parrywh commented Oct 3, 2020 •
edited

Describe the bug
Image disappears from display when applying crop in Safari v14

To Reproduce
Steps to reproduce the behavior:

  1. Open tab in Safari v14
  2. Navigate to https://ui.toast.com/tui-image-editor/
  3. Click Crop and Apply Crop Area to image
  4. Click Apply

Expected behavior
Image should be cropped according to crop area and displayed

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser Safari
  • Version 14
@parrywh parrywh added the Bug label Oct 3, 2020
@jinwoo-kim-nhn
Copy link
Contributor

Thanks for the tip. This is critical. I'll fix it quickly.

@parrywh
Copy link
Author

parrywh commented Oct 13, 2020

@jinwoo-kim-nhn any updates on the fix? thanks!

@GeekFreakInk
Copy link

it also happens on google chrome used on an Iphone X.

@parrywh
Copy link
Author

parrywh commented Oct 30, 2020

@jinwoo-kim-nhn any updates at all? thank you!

lja1018 added a commit that referenced this issue Dec 8, 2020
@lja1018
feat: update fabric version to 4.2.0 [#461] (#491)
792dfb1 
* feat: fabricjs version update 3.6.0 -> 4.2.0 - start prototyping

* feat: apply fabric v4.2.0 breaking changes

* test: fix fabric v4.2.0 breaking changes

* chore: change example cdn link

* fix: icon event drag error bug at IE

* env: update fabric version to 4.2.0

* chore: change misspelling

* chore: fix misspelling

* chore: apply code review

Co-authored-by: jinwoo-kim-nhn <[email protected]>
@lja1018 lja1018 mentioned this issue Dec 8, 2020
Merged
7 tasks
lja1018 added a commit that referenced this issue Dec 8, 2020
@lja1018 @jinwoo-kim-nhn
feat: v3.11.0 (#498)
96e47c7 
* feat: add undo stack of object resize/move [#358] (#490)

* feat: add objectModified handler

* feat: resize move add undo stack - middle commit

* feat: resize move add undo stack - middle commit 2

* feat: one item undo redo prototype complate

* feat: undo chage from group selection = #1

* feat: prototyping complete

* feat: add selectionModifyHelper

* feat: complate refactoring

* refactor: complete refactoring

* feat: added test for changeSelection command

* test: add selectionModifyHelper test

* chore: fix misspelling

* chore: apply code review

Co-authored-by: lja1018 <[email protected]>
Co-authored-by: jinwoo-kim-nhn <[email protected]>

* feat: update fabric version to 4.2.0 [#461] (#491)

* feat: fabricjs version update 3.6.0 -> 4.2.0 - start prototyping

* feat: apply fabric v4.2.0 breaking changes

* test: fix fabric v4.2.0 breaking changes

* chore: change example cdn link

* fix: icon event drag error bug at IE

* env: update fabric version to 4.2.0

* chore: change misspelling

* chore: fix misspelling

* chore: apply code review

Co-authored-by: jinwoo-kim-nhn <[email protected]>

* feat: add icon drawing mode [#74, #441] (#492)

* feat: add drawingmode for icon - prototyping complete

* feat: complete add drawing mode for icon

* chore: fix misspelling

* chore: apply code review

* fix: icon selection scale

Co-authored-by: jinwoo-kim-nhn <[email protected]>

* fix: text line-through decoration (#496)

* fix: not apply setBrush API when LINE_DRAWING (#497)

* feat: apply prettier (#493)

* env: add prettier

* chore: apply prettier

Co-authored-by: 김진우 <[email protected]>
Co-authored-by: jinwoo-kim-nhn <[email protected]>
@lja1018
Copy link
Contributor

lja1018 commented Dec 9, 2020

@parrywh
This issue was resolved in v3.11.0. Thank you!

@lja1018 lja1018 closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lja1018 @jinwoo-kim-nhn @parrywh @GeekFreakInk