Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event after editing text or for each change #419

Closed
marioviana opened this issue Jun 30, 2020 · 4 comments
Closed

Event after editing text or for each change #419

marioviana opened this issue Jun 30, 2020 · 4 comments
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation

Comments

@marioviana
Copy link

marioviana commented Jun 30, 2020

Version

Latest

Development Environment

Electron 9.0.4 & Mac OS Catalina 10.15.4

Current Behavior

Currently, we only have an event when the user starts editing the text. Also, this change doesn't enter on the undo stack, we cannot save the image after the user ends the text editing because we don't know when this happens.

Expected Behavior

An event when the user end the text editing or having each change triggering the event.

@marioviana marioviana added Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation labels Jun 30, 2020
@auto-comment
Copy link

auto-comment bot commented Jun 30, 2020

Thank you for raising an issue.
We will try and get back to you as soon as possible.

Please make sure you have filled out issue respecting our form in English and given us as much context as possible. If not, the issue will be closed or not replied.

@jinwoo-kim-nhn
Copy link
Contributor

Thanks for the problem. We will check and improve.

@gaslit
Copy link

gaslit commented Nov 8, 2020

Hello, is there any news regarding this fix? Many thanks. This is also linked to issue #387

lja1018 added a commit that referenced this issue Feb 22, 2021
* refactor: monorepo skeleton (#523)

* chore: make apps directory, move files to apps

* chore: fix test cases, misspellings and change NHN Ent to NHN

* chore: fix range tool options type

* feat: monorepo (#524)

* chore: init lerna options

* chore: Docs

* chore: Development environment

* interim

* feat: Add Storybook

* fix: Use uiSize option

* doc: Add README.md

* chore: Modify README.md

* chore: Modify README.md

* chore: Bundle v1.0.0

* Merge branch 'master' into production

* Merge branch 'master' into production

* chore: version up v1.0.1

* Merge branch 'master' into production

* chore: Bundle v1.1.0

* Merge branch 'master' into production

* chore: Bundle v1.2.0

* Merge branch 'master' into production

# Conflicts:
#	.gitignore

* Merge branch 'master' into production

* chore: import react wrapper

* chore: check npm bundle, change comment

* chore: update tuidoc config

* chore: update tslint.json

* feat: Implement vue wrapper for tui.ImageEditor

* docs: add homepage, repository info

* Merge pull request #1 from nhnent/feat/example

chore : add fast example using @vue/cli

* fix: update vue/cli (Security vulnerability response)

* chore: update v1.0.1

* chore: update tui-image-editor version

* chore: update tilde dependency package version

* 1.0.2

* Merge pull request #12 from nhnent/chore/change-company-name

chore: change company name(nhnent -> nhn)

* Merge pull request #17 from nhn/docs/links/nhnent-to-nhn

docs: update links 'nhnent' to 'nhn'

* fix: Remove 'editorInstance' from 'data' for memory issue (#19)

* fix: Remove editorInstance from data property

* chore: Modify example code

* chore: Update ImageEditor version to v3.7.0

* chore: Add 'example' to eslint exclude path

* fix: Apply code-review

* fix: Bind events passed to props only

* refactor: Remove event name filter

* chore: Modify ImageEditor version prefix to carrot

* chore: Update version to v1.1.0

* chore: Add 'postinstall' to package.json

* chore: update version to v1.2.0

* chore: update version to v1.2.1

* chore: update version to v1.3.0

* chore: import vue wrapper

* chore: apply prettier

* chore: fix README

* chore: update gitignore

* chore: update version to 3.12.0

* chore: change ASCII code %20 to space

* docs: update README

* chore: apply code review

Co-authored-by: junghwan-park <[email protected]>
Co-authored-by: jung-han <[email protected]>
Co-authored-by: 김진우 <[email protected]>
Co-authored-by: jungeun-cho <[email protected]>
Co-authored-by: jjo Cho <[email protected]>
Co-authored-by: 유동식 <[email protected]>
Co-authored-by: 박정환 <[email protected]>

Co-authored-by: junghwan-park <[email protected]>
Co-authored-by: jung-han <[email protected]>
Co-authored-by: 김진우 <[email protected]>
Co-authored-by: jungeun-cho <[email protected]>
Co-authored-by: jjo Cho <[email protected]>
Co-authored-by: 유동식 <[email protected]>
Co-authored-by: 박정환 <[email protected]>

* fix: not work filter in direct api example [#388] (#525)

* fix: classname error when clicking in the gap [#411] (#526)

* fix: not occur text changed event [#387, #419] (#527)

* fix: disappear image when apply crop [#359] (#528)

* env: fix editorconfig tabsize

* fix: image disappears when applying an empty cropzone (#359)

Co-authored-by: junghwan-park <[email protected]>
Co-authored-by: jung-han <[email protected]>
Co-authored-by: 김진우 <[email protected]>
Co-authored-by: jungeun-cho <[email protected]>
Co-authored-by: jjo Cho <[email protected]>
Co-authored-by: 유동식 <[email protected]>
Co-authored-by: 박정환 <[email protected]>
@lja1018
Copy link
Contributor

lja1018 commented Mar 10, 2021

@marioviana @gaslit
Thanks for the report. Resolved in v3.12.0.

@lja1018 lja1018 closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation
Projects
None yet
Development

No branches or pull requests

4 participants