Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the value not to be reflected in undoStack while dragging in the slider UI. #310

Closed
jinwoo-kim-nhn opened this issue Jan 23, 2020 · 0 comments
Labels
Enhancement Enhance performance or improve usability of original features.
Milestone

Comments

@jinwoo-kim-nhn
Copy link
Contributor

Version

3.7.3

Development Environment

mac, chrome

Current Behavior

Improve the value not to be reflected in undoStack while dragging in the slider UI.

@jinwoo-kim-nhn jinwoo-kim-nhn added the Enhancement Enhance performance or improve usability of original features. label Jan 23, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn added this to the v3.8.0 milestone Jan 23, 2020
jinwoo-kim-nhn added a commit that referenced this issue Feb 4, 2020
* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* fix: added jsdoc for missing jsdoc

* feat: some refactoring for remove event binding

* fix: rotation setAngle undo bug

* feat: improve undo slide behavior for text component - middle commit

* fix: undo redo bug for text menu - prototype commit

* feat: added test for text change undo redo

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* feat: some refactoring for remove event binding

* feat: improve undo slide behavior for text component - middle commit

* fix: undo redo bug for text menu - prototype commit

* feat: added test for text change undo redo

* fix: incorrected rebase line delete

* fix: unnessary text style property (textDecoration)

* fixed: some refactoring

* fix: fixed incorrected text option

* fix: apply codereview

Co-authored-by: superlucky84 <[email protected]>
jinwoo-kim-nhn added a commit that referenced this issue Feb 4, 2020
* fix: fixed undo redo bug for shape menu

* apply codereview
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
…hn#314)

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* fix: added jsdoc for missing jsdoc

* feat: some refactoring for remove event binding

* fix: rotation setAngle undo bug

* feat: improve undo slide behavior for text component - middle commit

* fix: undo redo bug for text menu - prototype commit

* feat: added test for text change undo redo

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* feat: some refactoring for remove event binding

* feat: improve undo slide behavior for text component - middle commit

* fix: undo redo bug for text menu - prototype commit

* feat: added test for text change undo redo

* fix: incorrected rebase line delete

* fix: unnessary text style property (textDecoration)

* fixed: some refactoring

* fix: fixed incorrected text option

* fix: apply codereview

Co-authored-by: superlucky84 <[email protected]>
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
)

* fix: fixed undo redo bug for shape menu

* apply codereview
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
* feat: slider undo redo for filter - middle commit

* middle commit

* feat: prototype complete

* fix: added test and refactoring

* refactor: add jsdoc with filter typename map

* refactor: isSilent for cacheUndodata

* apply codereview

Co-authored-by: superlucky84 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
None yet
Development

No branches or pull requests

1 participant