Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon Color Set #231

Closed
Cody0913 opened this issue Jul 23, 2019 · 0 comments
Closed

Icon Color Set #231

Cody0913 opened this issue Jul 23, 2019 · 0 comments
Labels
Feature New features to implement Need Discussion Need discussion or investigation

Comments

@Cody0913
Copy link

Version

v3.5.2

Development Environment

Chrome, Firefox, IE

Current Behavior

More of a proposal than an issue. I noticed that as of v3.2.0 one could supply a theme object. I also noticed however that the way that icons colors are determined is based on the icon set that is being used. As far as a possible ease of use to only support one icon set would it be easier to migrate to have all the icon strokes set to currentColor? And have the svg class .tui-image-editor-container .svg_ic-menu set the color in the stylesheet? This way anyone could possibly set the color through the theme object?

I would be more than happy to implement this myself even if this would be an addition that is beneficial and practical.

Expected Behavior

Easy to configure the icon colors through the theme object.
@junghwan-park junghwan-park added Feature New features to implement Need Discussion Need discussion or investigation labels Jul 24, 2019
This was referenced Feb 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New features to implement Need Discussion Need discussion or investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@junghwan-park @Cody0913 @jinwoo-kim-nhn