Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env: workspace #1447

Merged
merged 10 commits into from
Mar 22, 2021
Merged

env: workspace #1447

merged 10 commits into from
Mar 22, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Mar 22, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • added npm workspace
"workspaces": [
  "apps/editor",
  "libs/*",
  "plugins/*"
]
  • removed local dependencies in monorepo
  • replaced any type definition of plugins with apps/editor type through workspace

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz merged commit 2f89221 into next Mar 22, 2021
@js87zz js87zz deleted the env/workspace branch March 22, 2021 07:00
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
env: workspace (nhn#1447)
37c5833 
* chore: apply npm workspaces

* chore: fix eslint rule

* chore: apply workspace import to plugin, editor app

* fix: broken type def

* chore: skipLibCheck optino for tsconfig

* fix: inject pmState, pmView to plugin default options

* chore: update wrapper type def

* chore: fix broken config in uml

* chore: remove unnecessary dependencies in code syntax

* chore: fix broken webpack server in chart plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@js87zz