Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for higher sequence lenghts #7

Open
wants to merge 1 commit into
base: fairseq_v2
Choose a base branch
from
Open

Fixes for higher sequence lenghts #7

wants to merge 1 commit into from

Conversation

ruanslv
Copy link
Collaborator

@ruanslv ruanslv commented Sep 7, 2022

Simple changes just extending switches and asserts

@ngoyal2707
Copy link
Owner

is it okay with you if we merge this directly to v3? and we can push the small PR to metaseq to make it work with v3?

@ruanslv
Copy link
Collaborator Author

ruanslv commented Sep 12, 2022

@ngoyal2707 would you be ok with a merge here too? Your metaseq PR (https://github.com/facebookresearch/metaseq/pull/300/commits) as a whole makes it possible to use fairseq_v3, but the Namespace change alone is not enough in my local tests. I've tried a few different things but couldn't figure out what else exactly from the metaseq branch I'd need to include.

Given you are working on merging your changes anyway, I thought best option would be: keep fairseq_v2 for now for seq_len tests, and when your PR is fully merged we go back to fairseq_v3.

Stack trace of error I'm getting: P528724412

Other things I've tried and didn't work:

Command I'm using to test:
$ python -m metaseq_internal.fb_sweep.sweep_openlm_baselines -n 1 -g 8 -t 1 -p test_fv3 --azure --local --model-size 125m --checkpoints-dir /shared/home/ruanrms/checkpoints/test_fv3/ --no-wandb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants