Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace class attribute to className #505

Merged
merged 1 commit into from
Oct 22, 2022
Merged

fix: replace class attribute to className #505

merged 1 commit into from
Oct 22, 2022

Conversation

amit-ksh
Copy link
Contributor

Fixes Issue

My PR closes #503

Changes proposed

What were you told to do ?

To replace all the class attribute occurrences from the components and pages with className

What did you do ?

Changed all the occurrences of class attribute to className


Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Screenshots

@vercel
Copy link

vercel bot commented Oct 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
milan ✅ Ready (Inspect) Visit Preview Oct 22, 2022 at 2:02AM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello contributor, thank you for opening a Pull Request 🎉.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out Tamal Das on Twitter.
Star ⭐ this repo to show us support.

Happy, Open Source!

@vercel vercel bot temporarily deployed to Preview October 22, 2022 02:02 Inactive
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟧 priority: high 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. good first issue Good for beginners to work on. labels Oct 22, 2022
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

  • ⚒ Thankyou for working on the issue
  • ⭐ Do star the repo, to get updates on more issues !
  • 💚 Keep contributing to Opensource

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. hacktoberfest-accepted This PR is accepted for Hacktoberfest. and removed status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Oct 22, 2022
@tamalCodes tamalCodes merged commit 03f32ca into ngoworldcommunity:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. 🐞 bug This is a patch, generally fixing some bugs. good first issue Good for beginners to work on. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React components and pages uses class attribute instead of className
2 participants