Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the unhandled promises in routes #498

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Fixed the unhandled promises in routes #498

merged 6 commits into from
Oct 20, 2022

Conversation

SteveSayantan
Copy link
Contributor

@SteveSayantan SteveSayantan commented Oct 18, 2022

Fixes Issue

Closes #493

Changes proposed

What were you told to do ?

To fix the issue with promise handling in routes

What did you do ?

Fixed the issue with promise handling in routes


Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
milan ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 5:51PM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello contributor, thank you for opening a Pull Request 🎉.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out Tamal Das on Twitter.
Star ⭐ this repo to show us support.

Happy, Open Source!

@vercel vercel bot temporarily deployed to Preview October 18, 2022 16:58 Inactive
@SteveSayantan SteveSayantan changed the title Fixed Fixed the unhandled promises in routes Oct 18, 2022
@vercel vercel bot temporarily deployed to Preview October 20, 2022 17:51 Inactive
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟧 priority: high 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Oct 20, 2022
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

  • ⚒ Thankyou for working on the issue
  • ⭐ Do star the repo, to get updates on more issues !
  • 💚 Keep contributing to Opensource

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. hacktoberfest-accepted This PR is accepted for Hacktoberfest. labels Oct 20, 2022
@tamalCodes tamalCodes merged commit adbcd3a into ngoworldcommunity:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. 🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper handling of the Promise returned by mongoose save() method
2 participants