Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a eslint rule that forbids import from @angular/forms #4

Closed
NetanelBasal opened this issue May 17, 2020 · 5 comments
Closed
Assignees

Comments

@NetanelBasal
Copy link
Member

No description provided.

@NetanelBasal
Copy link
Member Author

Assign to Coly010

@Coly010 Coly010 self-assigned this May 17, 2020
@NetanelBasal NetanelBasal changed the title Create a lint rule that forbids import from @angular/forms Create a eslint rule that forbids import from @angular/forms May 17, 2020
@Coly010
Copy link
Collaborator

Coly010 commented May 17, 2020

The eslint rule will most likely need to be delivered as an eslint plugin.
This will involve the creation of a new npm package in the form: @ngneat/eslint-plugin-reactive-forms

By delivering this rule as a plugin, it can be recommended to be installed, or installed as part of the install of the library, but it doesn't have to be forced upon people who may not want it, or who work across a monorepo where one project uses this library and different project doesn't.

Thoughts on this?

@NetanelBasal
Copy link
Member Author

Agree. Create a new lib here, please.

@Coly010
Copy link
Collaborator

Coly010 commented May 17, 2020

ESLint recommends using Yeoman generator to scaffold the ESLint Plugin and Rule.
I'm going to follow this approach to allow any potential contributors to be able to reuse knowledge gained from previous experiences working with ESLint Rules + Plugins

@NetanelBasal
Copy link
Member Author

Sure.

Coly010 added a commit that referenced this issue May 17, 2020
Add ESLint Plugin to check for imports from `@angular/forms`.

Closes: #4
Coly010 added a commit that referenced this issue May 17, 2020
Add ESLint Plugin to check for imports from `@angular/forms`.

Closes: #4
Coly010 added a commit that referenced this issue May 17, 2020
Add ESLint Plugin to check for imports from `@angular/forms`.

Closes: #4
Coly010 added a commit that referenced this issue May 17, 2020
Add ESLint Plugin to check for imports from `@angular/forms`.

Closes: #4
Coly010 added a commit that referenced this issue May 18, 2020
Add ESLint Plugin to check for imports from `@angular/forms`.

Closes: #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants