Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a schematics command that converts from angular imports to ours #3

Closed
NetanelBasal opened this issue May 17, 2020 · 15 comments
Closed
Assignees

Comments

@NetanelBasal
Copy link
Member

Convert import from '@angular/forms' to @ngneat/reactive-forms

@NetanelBasal
Copy link
Member Author

Assign to Coly010

@Coly010 Coly010 self-assigned this May 17, 2020
@itayod
Copy link
Contributor

itayod commented May 19, 2020

@Coly010 this might be helpful

@Coly010
Copy link
Collaborator

Coly010 commented May 20, 2020

@itayod thank you!

@NetanelBasal
Copy link
Member Author

@Coly010 any progress here?

@Coly010
Copy link
Collaborator

Coly010 commented May 23, 2020 via email

@NetanelBasal
Copy link
Member Author

Thanks. It's the only thing that left. The docs are ready, and I'll start working on the article.

@Coly010
Copy link
Collaborator

Coly010 commented May 23, 2020 via email

@NetanelBasal
Copy link
Member Author

Thanks!

@itayod
Copy link
Contributor

itayod commented May 23, 2020

@Coly010 thanks, for any help you might need feel free to reach me out.

@Coly010
Copy link
Collaborator

Coly010 commented May 24, 2020 via email

@NetanelBasal
Copy link
Member Author

Sure. @itayod will take it

@NetanelBasal NetanelBasal assigned itayod and unassigned Coly010 May 24, 2020
@NetanelBasal
Copy link
Member Author

@Coly010 when you can please add the FormBuilder service to the eslint plugin.

@NetanelBasal
Copy link
Member Author

NetanelBasal commented May 24, 2020

Schematics command functionality:

Check each file and replace the following:

  • Before:
import { FormControl, FormGroup, FormArray, FormBuilder } from '@angular/forms';
  • After:
import { FormControl, FormGroup, FormArray, FormBuilder } from '@ngneat/reactive-forms';

Pay attention to the following case:
import { FormControl, FormGroup, ControlValueAccessor, FormBuilder } from '@angular/core'

In this case, the result should be:

import { ControlValueAccessor } from '@angular/forms';
import { FormControl, FormGroup, FormBuilder } from '@ngneat/reactive-forms';

@itayod
Copy link
Contributor

itayod commented May 24, 2020

@NetanelBasal What do you think should be the name of the command? "migrate"?

@NetanelBasal
Copy link
Member Author

migrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants