-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a schematics command that converts from angular imports to ours #3
Comments
Assign to Coly010 |
@itayod thank you! |
@Coly010 any progress here? |
Going to start work on it tomorrow
…On Sat, 23 May 2020, 19:27 Netanel Basal, ***@***.***> wrote:
@Coly010 <https://github.com/Coly010> any progress here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4T7M3EA6RWR7KVD7SLVCDRTAIQXANCNFSM4NDOUGQQ>
.
|
Thanks. It's the only thing that left. The docs are ready, and I'll start working on the article. |
I'll have it finished tomorrow then!
…On Sat, 23 May 2020, 19:32 Netanel Basal, ***@***.***> wrote:
Thanks. It's the only thing that left. The docs are ready, and I'll start
working on the article.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4T7MZOS5EVHR7WANEEQZLRTAJCTANCNFSM4NDOUGQQ>
.
|
Thanks! |
@Coly010 thanks, for any help you might need feel free to reach me out. |
Sorry, would someone else be able to pick this up. I've just had a few
things come up and I don't think I'll have the time to sit down to it today
…On Sat, 23 May 2020, 19:39 Itay Oded, ***@***.***> wrote:
@Coly010 <https://github.com/Coly010> thanks, for any help you might need
feel free to reach me out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4T7M67BMESLFW4TE7RNCLRTAJ7RANCNFSM4NDOUGQQ>
.
|
Sure. @itayod will take it |
@Coly010 when you can please add the FormBuilder service to the eslint plugin. |
Schematics command functionality: Check each file and replace the following:
import { FormControl, FormGroup, FormArray, FormBuilder } from '@angular/forms';
import { FormControl, FormGroup, FormArray, FormBuilder } from '@ngneat/reactive-forms'; Pay attention to the following case: In this case, the result should be: import { ControlValueAccessor } from '@angular/forms';
import { FormControl, FormGroup, FormBuilder } from '@ngneat/reactive-forms'; |
@NetanelBasal What do you think should be the name of the command? "migrate"? |
migrate |
Convert
import from '@angular/forms'
to@ngneat/reactive-forms
The text was updated successfully, but these errors were encountered: