Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 14 #164

Closed
undsoft opened this issue Jun 10, 2022 · 1 comment · Fixed by #165
Closed

Support for Angular 14 #164

undsoft opened this issue Jun 10, 2022 · 1 comment · Fixed by #165

Comments

@undsoft
Copy link
Contributor

undsoft commented Jun 10, 2022

Is this a regression?

No

Description

Using library in Angular 14 results in:

Error: node_modules/@ngneat/reactive-forms/lib/form-builder.d.ts:8:5 - error TS2416: Property 'array' in type 'FormBuilder' is not assignable to the same property in base type 'FormBuilder'.
  Type '<T, Control extends AbstractControl<any, any> = T extends Record<any, any> ? FormGroup<ControlsOf<T>> : FormControl<T>>(controlsConfig: Control[], validatorOrOpts?: ValidatorFn | ... 1 more ... | AbstractControlOptions, asyncValidator?: AsyncValidatorFn | AsyncValidatorFn[]) => FormArray<...>' is not assignable to type '<T>(controls: T[], validatorOrOpts?: ValidatorFn | ValidatorFn[] | AbstractControlOptions, asyncValidator?: AsyncValidatorFn | AsyncValidatorFn[]) => FormArray<...>'.
    Types of parameters 'controlsConfig' and 'controls' are incompatible.
      Type 'T[]' is not assignable to type 'AbstractControl<any, any>[]'.
        Type 'T' is not assignable to type 'AbstractControl<any, any>'.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

No response

Anything else?

No response

Do you want to create a pull request?

Yes

undsoft added a commit to undsoft/reactive-forms that referenced this issue Jun 10, 2022
BREAKING CHANGE: The library now requires Angular v14

Closes ngneat#164
@undsoft
Copy link
Contributor Author

undsoft commented Jun 10, 2022

@NetanelBasal Will you release it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant