Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to install newest version (ngcc fails) #114

Closed
steflen opened this issue Oct 27, 2021 · 5 comments
Closed

unable to install newest version (ngcc fails) #114

steflen opened this issue Oct 27, 2021 · 5 comments

Comments

@steflen
Copy link

steflen commented Oct 27, 2021

Is this a regression?

Yes

Description

cant install the library, fails at postinstall step

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/angular-ivy-bwiuec

Please provide the exception or error you saw

yarn run ngcc --properties es2015 browser module main
Compiling @ngneat/reactive-forms : es2015 as esm2015
Compiling @ngneat/reactive-forms : main as umd
Error: Error on worker #1: TypeError: Cannot read property '1' of undefined
at renderFactoryParameters (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.js:201:51)
at UmdRenderingFormatter.addImports (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.js:63:13)
at Renderer.renderFile (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/rendering/renderer.js:94:35)
at ~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/rendering/renderer.js:53:108
at Array.forEach (<anonymous>)
at Renderer.renderProgram (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/rendering/renderer.js:48:54)
at Transformer.transform (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/packages/transformer.js:88:42)
at ~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/execution/create_compile_function.js:52:42
at ~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/worker.js:85:54
at step (~/n1pp3lzw1c3R/node_modules/tslib/tslib.js:143:27)
at ClusterMaster.onWorkerMessage (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:195:27)
at ~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:55:95
at ClusterMaster.<anonymous> (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:293:57)
at step (~/n1pp3lzw1c3R/node_modules/tslib/tslib.js:143:27)
at Object.next (~/n1pp3lzw1c3R/node_modules/tslib/tslib.js:124:57)
at ~/n1pp3lzw1c3R/node_modules/tslib/tslib.js:117:75
at new Promise (<anonymous>)
at Object.__awaiter (~/n1pp3lzw1c3R/node_modules/tslib/tslib.js:113:16)
at EventEmitter.<anonymous> (~/n1pp3lzw1c3R/node_modules/@angular/compiler-cli/ngcc/src/execution/cluster/master.js:287:32)
at EventEmitter.emit (events.js:400:28)

Please provide the environment you discovered this bug in

stackblitz, angular@12, nrwl@13

Anything else?

wild guess: here you've changed the builder from angular to nx
5cee6fe#diff-2d2675bb4687601a5c7ccf707455132f90f3516a33716185687e5c41df59ac7dR140

Do you want to create a pull request?

No

@NetanelBasal
Copy link
Member

Works for me

@steflen
Copy link
Author

steflen commented Oct 27, 2021

oh my bad !! forgot to save the stackblitz dependencies
pls try again now https://stackblitz.com/edit/angular-ivy-bwiuec

@NetanelBasal
Copy link
Member

Please show that it fails locally with npm.

@NetanelBasal
Copy link
Member

image

@steflen
Copy link
Author

steflen commented Oct 27, 2021

thanks man
lets wait for v13 which removes umd bundle generation (ng-packager)

@steflen steflen closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants