feat(library): refactor the entire code base

BREAKING CHANGE: refactor the entire code

I completely rewrote the library from scratch for two reasons:
1. Provide as much support as possible without introducing bugs, breaking strict mode, or creating an inconvenient API.
2. Reduce the library size.

Here are the changes:
- Angular's peer dependency is now `>= 12`.
- FormGroup's generic was removed in favor of the **experimental** `ControlsOf` interface.
- Remove `mergeValidators`.  Use addValidators in v12.
- Remove `validateOn`.
- Remove `getControl` in favor of `get(key)` or `get(['nested', 'key'])`.
- Remove errors typing.
- Validators should now be imported from Angular.
- `FormBuilder` doesn't support generic anymore. Due to the complexity of the builder API, we're currently couldn't create a "good" implementation of `ControlsOf` for the builder.
- Remove the `group.persist()` from the instance to an exported function to make it tree-shakeable.

Fixes #197,#103,#102,#97,#100

.editorconfig

@@ -1,4 +1,4 @@
-# Editor configuration, see https:https://editorconfig.org
+# Editor configuration, see http:https://editorconfig.org
 root = true
 
 [*]
@@ -8,9 +8,6 @@ indent_size = 2
 insert_final_newline = true
 trim_trailing_whitespace = true
 
-[*.ts]
-quote_type = single
-
 [*.md]
 max_line_length = off
 trim_trailing_whitespace = false

.eslintrc.json

@@ -0,0 +1,35 @@
+{
+ "root": true,
+ "ignorePatterns": ["**/*"],
+ "plugins": ["@nrwl/nx"],
+ "overrides": [
+ {
+ "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
+ "rules": {
+ "@nrwl/nx/enforce-module-boundaries": [
+ "error",
+ {
+ "enforceBuildableLibDependency": true,
+ "allow": [],
+ "depConstraints": [
+ {
+ "sourceTag": "*",
+ "onlyDependOnLibsWithTags": ["*"]
+ }
+ ]
+ }
+ ]
+ }
+ },
+ {
+ "files": ["*.ts", "*.tsx"],
+ "extends": ["plugin:@nrwl/nx/typescript"],
+ "rules": {}
+ },
+ {
+ "files": ["*.js", "*.jsx"],
+ "extends": ["plugin:@nrwl/nx/javascript"],
+ "rules": {}
+ }
+ ]
+}

.github/ISSUE_TEMPLATE/1-bug-report.yaml

@@ -0,0 +1,52 @@
+name: Bug Report
+description: Report a bug in the Reactive Forms Library
+
+body:
+ - type: dropdown
+ id: is-regression
+ attributes:
+ label: Is this a regression?
+ options:
+ - 'Yes'
+ - 'No'
+ validations:
+ required: true
+
+ - type: textarea
+ id: description
+ attributes:
+ label: Description
+ validations:
+ required: true
+
+ - type: input
+ id: reproduction
+ attributes:
+ label: Please provide a link to a minimal reproduction of the bug
+
+ - type: textarea
+ id: exception-or-error
+ attributes:
+ label: Please provide the exception or error you saw
+ render: true
+
+ - type: textarea
+ id: environment
+ attributes:
+ label: Please provide the environment you discovered this bug in
+ render: true
+
+ - type: textarea
+ id: other
+ attributes:
+ label: Anything else?
+
+ - type: dropdown
+ id: contribute
+ attributes:
+ label: Do you want to create a pull request?
+ options:
+ - 'Yes'
+ - 'No'
+ validations:
+ required: true

.github/ISSUE_TEMPLATE/2-feature-request.yaml

@@ -0,0 +1,34 @@
+name: 'Feature Request'
+description: Suggest a feature for Reactive Forms Library
+
+body:
+ - type: textarea
+ id: description
+ attributes:
+ label: Description
+ validations:
+ required: true
+
+ - type: textarea
+ id: proposed-solution
+ attributes:
+ label: Proposed solution
+ validations:
+ required: true
+
+ - type: textarea
+ id: alternatives-considered
+ attributes:
+ label: Alternatives considered
+ validations:
+ required: true
+
+ - type: dropdown
+ id: contribute
+ attributes:
+ label: Do you want to create a pull request?
+ options:
+ - 'Yes'
+ - 'No'
+ validations:
+ required: true

.github/ISSUE_TEMPLATE/3-support-request.md

@@ -0,0 +1,12 @@
+---
+name: 'Support Request'
+about: Questions and requests for support
+---
+
+Please do not file questions or support requests on the GitHub issues tracker.
+
+You can get your questions answered using other communication channels. Please see:
+
+https://github.com/ngneat/reactive-forms/discussions
+
+Thank you!

PULL_REQUEST_TEMPLATE.md → .github/PULL_REQUEST_TEMPLATE.md

@@ -2,7 +2,7 @@
 
 Please check if your PR fulfills the following requirements:
 
-- [ ] The commit message follows our guidelines: CONTRIBUTING.md#commit
+- [ ] The commit message follows our guidelines: https://github.com/ngneat/reactive-forms/blob/master/CONTRIBUTING.md#commit
 - [ ] Tests for the changes have been added (for bug fixes / features)
 - [ ] Docs have been added / updated (for bug fixes / features)
 

.github/workflows/ci.yml

@@ -0,0 +1,43 @@
+name: '@ngneat/reactive-forms'
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: true
+
+ steps:
+ - uses: actions/checkout@v2
+ - name: Cache node modules
+ uses: actions/cache@v2
+ env:
+ cache-name: cache-node-modules
+ with:
+ path: ~/.npm
+ key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+ restore-keys: |
+ ${{ runner.os }}-build-${{ env.cache-name }}-
+ ${{ runner.os }}-build-
+ ${{ runner.os }}-
+ - uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ cache: 'npm'
+
+ - name: Install dependencies
+ run: npm i
+
+ - name: Run ESLint
+ run: npm run lint:all
+
+ - name: Run Build
+ run: npm run build:all
+
+ - name: Run unit tests
+ run: npm run test:all

.gitignore

@@ -4,17 +4,10 @@
 /dist
 /tmp
 /out-tsc
-/projects/ngneat/reactive-forms/src/lib/type-tests/out-tsc
-# Only exists if Bazel was run
-/bazel-out
 
 # dependencies
 node_modules
 
-# profiling files
-chrome-profiler-events*.json
-speed-measure-plugin*.json
-
 # IDEs and editors
 /.idea
 .project
@@ -30,7 +23,6 @@ speed-measure-plugin*.json
 !.vscode/tasks.json
 !.vscode/launch.json
 !.vscode/extensions.json
-.history/*
 
 # misc
 /.sass-cache
@@ -45,4 +37,3 @@ testem.log
 # System Files
 .DS_Store
 Thumbs.db
-.cache