feat(form-array): implement remove helpers

ngneat · Aug 14, 2020 · 0011944 · 0011944
1 parent 419c8c2
commit 0011944
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/projects/ngneat/reactive-forms/src/lib/formArray.ts b/projects/ngneat/reactive-forms/src/lib/formArray.ts
@@ -192,10 +192,16 @@ export class FormArray<T = any, E extends object = any> extends NgFormArray {
  }
 
  remove(value: T) {
- throw Error('NotImplemented');
+ this.removeWhen(v => v.value === value);
  }
 
  removeWhen(predicate: (element: AbstractControl<T>) => boolean) {
- throw Error('NotImplemented');
+ const toRemove: number[] = [];
+ for (let i = 0; i < this.length; ++i) {
+ if (predicate(this.at(i))) {
+ toRemove.push(i);
+ }
+ }
+ toRemove.sort((idx1, idx2) => idx2 - idx1).forEach(idx => this.removeAt(idx));
  }
 }