Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new features for ControErrorDirective and fix one bug #80

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Add new features for ControErrorDirective and fix one bug #80

merged 3 commits into from
Sep 1, 2022

Conversation

Sir-J
Copy link
Contributor

@Sir-J Sir-J commented Sep 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

controlErrorsClass now gets value from attribute or from global config.

Bugfix: If for control sets controlErrorsClass and after we are change value, DefaultErrorComponent doesn't remove this class from host element.
For example: if custom class has border property this border always shows.

Issue Number: N/A

What is the new behavior?

For ControlErrorDirective added new property controlCustomClass. This class will be added for control, if he has error. This property gets value from attribute or from global config.

For ConfigProvider added two properties: controlCustomClass and controlErrorsClass

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

qwewer

Sergey Rogachev added 3 commits September 1, 2022 18:30
bufix: if text unset for default error component, custom classes stay added
docs: update
playground: update
@NetanelBasal NetanelBasal merged commit 8a037e2 into ngneat:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants