Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update test app custom error component's property names #20

Merged
merged 14 commits into from
Jul 14, 2020
Merged

fix: update test app custom error component's property names #20

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fc90011
feat(config): custom error component & positioning
harikvpy Jun 26, 2020
028541d
fix(config): changes for PR #15 review feedback
harikvpy Jun 29, 2020
da29053
fix(config): changes for PR #15 review feedback
harikvpy Jun 29, 2020
0f707bd
fix(config): changes for PR #15 review 2
harikvpy Jul 6, 2020
bff260e
fix(config): changes for PR #15 review 2
harikvpy Jul 6, 2020
4ffed1e
chore: merge incoming changes
harikvpy Jul 6, 2020
1fda3b4
fix(config): add test for anchor function destroy callback
harikvpy Jul 7, 2020
8e0e72a
chore: merge changes from upstream
harikvpy Jul 8, 2020
5b2a6bd
chore: code cleanup
harikvpy Jul 9, 2020
135514f
fix: readme formatting error
harikvpy Jul 9, 2020
859f475
docs: update config section
harikvpy Jul 10, 2020
a87a33a
docs: add @harikvpy as a contributor
harikvpy Jul 10, 2020
85d2746
Merge branch 'master' of https://github.com/ngneat/error-tailor
harikvpy Jul 13, 2020
3e7f128
fix: update custom error component variable names
harikvpy Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: merge changes from upstream
  • Loading branch information
@harikvpy
harikvpy committed Jul 8, 2020
commit 8e0e72a9b7af9e30e63fd9008ca3cf7deef625c1
2 changes: 2 additions & 0 deletions projects/ngneat/error-tailor/src/lib/control-error.directive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import { byPlaceholder, byText, createComponentFactory, Spectator } from '@ngnea
import { ErrorTailorModule } from '@ngneat/error-tailor';
import { tick, fakeAsync } from '@angular/core/testing';
import { DefaultControlErrorComponent } from './control-error.component';
import { Observable, asyncScheduler, scheduled } from 'rxjs';
import { map } from 'rxjs/operators';

function getComponentFactory<C>(component: Type<C>) {
return createComponentFactory({
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.